Patch for 2.3.9 mod time bug

Bron Gondwana brong at fastmail.fm
Wed Oct 3 09:12:03 EDT 2007


On Sun, Sep 02, 2007 at 09:51:09PM +0200, Michael Glad wrote:
> I also observe the 2.3.8/9 problem with sync_server not properly
> setting the mtime of sync'ed messages. 
> 
> The problem seems to be that the sync_message_fsync routine
> writes (flushes) to the message file after the utime call.
> 
> I've made the enclosed patches which solve the problems at least
> for me. It records the proper utime in an extra field of the
> sync_message structure which is fed to a utimes call after
> the flushing has been done.
> 
> 	-- Michael Glad, CS Dept, Aarhus University, Denmark

There has been some discussion of this same issue on a bugzilla
thread here:

https://bugzilla.andrew.cmu.edu/show_bug.cgi?id=2979

My reading of the manpages on my system is that "utimes()" is
deprecated (and besides we only have a resolution of 1 second
from the headers anyway) so I recommended going with the patch
that uses utime().

You should certainly see something that works correctly in the
next release though based on the interest this is getting.

Bron.


More information about the Cyrus-devel mailing list