CORRECT PATCH Re: sync_client bails when encountering a deleted message

Bron Gondwana brong at fastmail.fm
Wed May 16 22:46:19 EDT 2007


On Tue, May 15, 2007 at 10:21:05AM -0400, John Capo wrote:
> Quoting Ken Murchison (murch at andrew.cmu.edu):
> > Ken Murchison wrote:
> > >Obviously, the chances of header_size being 0xdeadbeef is remote, but it 
> > >is possible.  Would it make more sense to use ULONG_MAX as the "failure 
> > >size"?
> > 
> > Or better yet, how about just using 0 (zero)?  IIRC, RFC2822 stipulates 
> > that the message header has to be non-zero (Date and From are mandatory)
> 
> I have seen zero size messages created with IMAP uploads from desktop
> clients.  This is probably a bug elsewhere.  I do not know if the
> zero size messages were replicated.

Reconstruct will remove them from the index and unlink them if it sees
them.  Can't answer the replication question off the top of my head
though.


More information about the Cyrus-devel mailing list