\HasChildren incorrect

[Ken Murchison]

Martin Konold wrote:
> Hi,
> 
> There was the known issue https://bugzilla.andrew.cmu.edu/show_bug.cgi?id=2777 
> with incorrect \HasChildren server responses.
> 
> The problem appeared only with skiplist or berkley db mailboxes.db but not 
> with the format.
> 
> I created a patch for inclusion in the current HEAD version of Cyrus Imapd.
> 
>     https://bugzilla.andrew.cmu.edu/attachment.cgi?id=445&action=view
> 
> Ken, please consider to apply this patch as it really fixes a bug for which a 
> lot of clients (inlcuding Mozilla Thunderbird) only have partly working 
> workarounds.

I like the design of the patch, but I'm not sure that using the mailbox 
sort order is correct for ALL databases (seen state, annotations). 
Perhaps the comparator function should be selectable by a flag.  I need 
to think about this a little bit.


> The implementation is written with efficiency in mind.
> 
> BTW: What is the future of the bdb backend? 

Its still the most efficient backend for random access databases like 
deliver.db and tls_sessions.db

-- 
Kenneth Murchison
Systems Programmer
Project Cyrus Developer/Maintainer
Carnegie Mellon University