[Cyrus-CVS] Commits that didn't get emailed last week

[Bron Gondwana]

Hi everyone, these 5 commits didn't get emailed to the list because my
andrew email address wasn't on the mailing list yet.  Sorry.

---------------------------------------------------------------------------

Modified Files:
        append.c append.h
Log Message:
Correctly truncate cache file on aborted append

We were truncating to the size of the mmaped area rather than the
length of the file, causing blocks of bogus zero bytes in the
resulting cache file after an aborted append.


--- links to diffs follow ---
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/append.c.diff?r1=1.115&r2=1.116
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/append.h.diff?r1=1.30&r2=1.31

---------------------------------------------------------------------------

Modified Files:
        sync_client.c
Log Message:
Fix sync of non-user mailboxes

If a non-user mailbox is being considered for promotion to a USER
event in sync_client, it trys to xstrdup the folder name starting
at the user name - except that's a NULL string and it segfaults.

Only xstrdup if it actually is a user mailbox.


--- links to diffs follow ---
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/sync_client.c.diff?r1=1.37&r2=1.38

---------------------------------------------------------------------------

Modified Files:
        user.c
Log Message:
Fix ACL copying when renaming users

It had been replacing the buffer and setting ACLs to contain every
character
in every username or acl after the named user during the rename.


--- links to diffs follow ---
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/user.c.diff?r1=1.24&r2=1.25

---------------------------------------------------------------------------

Modified Files:
        imapd.c
Log Message:
Log "USER" events after renaming a user's "INBOX" to a new username.

Allows the old meta files to be cleaned up, and ensures the new ones are
copied.


--- links to diffs follow ---
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/imapd.c.diff?r1=1.553&r2=1.554

---------------------------------------------------------------------------

Modified Files:
        cyr_synclog.c imapd.c mboxlist.c mboxlist.h sync_client.c
        sync_log.h
Log Message:
Check subscription database rather than explicit ADDSUB/DELSUB

We were seeing occasional subscription mismatches at FastMail,
and the root cause was traced back to the re-ordering of log
files.  All the ADDSUB commands would run first, then all the
DELSUB commands.

If a log file contained a DELSUB followed by an ADDSUB, they
would be re-ordered, and the subscription would exists on the
master but not the replica.

This patch changes the specialness of subscriptions, so that
instead of SUB and UNSUB events, it's just SUB events, and the
sync_client will check the subscription database to find what
the value should be, then tell the backend to make it so.


--- links to diffs follow ---
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/cyr_synclog.c.diff?r1=1.3&r2=1.4
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/imapd.c.diff?r1=1.554&r2=1.555
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mboxlist.c.diff?r1=1.260&r2=1.261
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mboxlist.h.diff?r1=1.43&r2=1.44
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/sync_client.c.diff?r1=1.38&r2=1.39
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/sync_log.h.diff?r1=1.3&r2=1.4

---------------------------------------------------------------------------

So, from now on you'll be getting regular commit messages from me I'm
sure.  Got a few more patches to push into CVS for now, and then I'll
be working on a couple of issues that we're still tracking down.

Bron.