[Cyrus-CVS] src/cyrus/imap by murch

murch at andrew.cmu.edu murch at andrew.cmu.edu
Tue Nov 27 10:31:30 EST 2007


Update of /afs/andrew/system/cvs/src/cyrus/imap
In directory unix34.andrew.cmu.edu:/var/tmp/cvs-serv19692

Modified Files:
	imapd.c mboxlist.c mboxlist.h mboxname.c mboxname.h 
Log Message:
Fix Delayed Delete replication

Deleting user.foo was broken 

Also, it was leaving foo.TIMESTAMP.sub files because
it considered that to be a valid "user".

This patch takes a different approach (on top of the
delayed delete code already in Cyrus 2.3.10):

1) mboxname_isusermailbox() no longer returns true for
   DELETED.user.foo.TIMESTAMP

2) The "can I rename this" code checks for the target
   name being either another username or something in the
   DELETED. namespace.
2a) mboxname_isdeletedmailbox() rather than the somewhat
   (IMHO) misplaced mboxlist_in_deletedhierarchy().

3) if "forceuser" is passed (only done by sync_server),
   then all ACL checks are completely bypassed, so the
   rename will always succeed on the replica.



--- links to diffs follow ---
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/imapd.c.diff?r1=1.536&r2=1.537
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mboxlist.c.diff?r1=1.254&r2=1.255
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mboxlist.h.diff?r1=1.41&r2=1.42
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mboxname.c.diff?r1=1.41&r2=1.42
http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mboxname.h.diff?r1=1.15&r2=1.16


More information about the Cyrus-cvs mailing list