struct_et_list warnings with 2.3.9

[Larry Rosenbaum]

See also https://bugzilla.andrew.cmu.edu/show_bug.cgi?id=2805


> -----Original Message-----
> From: info-cyrus-bounces at lists.andrew.cmu.edu [mailto:info-cyrus-
> bounces at lists.andrew.cmu.edu] On Behalf Of Wesley Craig
> Sent: Friday, September 07, 2007 10:12 PM
> To: David Newman
> Cc: info-cyrus at lists.andrew.cmu.edu
> Subject: Re: struct_et_list warnings with 2.3.9
> 
> It's broken.  See:
> 
> 	https://bugzilla.andrew.cmu.edu/show_bug.cgi?id=2971
> 
> There are a number of problems with the current arrangement, many of
> which are compounded by the namespace collision of every other
> package that uses com_err.
> 
> :wes
> 
> On 07 Sep 2007, at 16:55, David Newman wrote:
> > There may be a missing #include for a header file in the cyrus 2.3.9
> > sources.
> >
> > Running make on cyrus 2.3.9 from the FreeBSD 6.2 ports collection
> > produces lots of these warnings:
> >
> > "struct_et_list" declared inside parameter list.
> >
> > I erroneously thought this was because I was using the UoA patches,
> > but
> > that's not it. Aristotelis kindly debugged the issue:
> >
> > "To keep your compilation warning free in file:
> > et/com_err.h  in the end (about line 102) just before the lines:
> >
> > #define __COM_ERR_H
> > #endif /* ! defined(__COM_ERR_H) */
> >
> > just add the line:
> > #include "error_table.h"
> >
> > for me it helpded the situation a lot."
> >
> > And for me too: After adding this include, make ran without warnings.
> >
> > Thanks to Arisotelis for providing this fix.
> 
> ----
> Cyrus Home Page: http://cyrusimap.web.cmu.edu/
> Cyrus Wiki/FAQ: http://cyrusimap.web.cmu.edu/twiki
> List Archives/Info: http://asg.web.cmu.edu/cyrus/mailing-list.html