[PATCH] close potential buffer overflow in prot_flush (was: Re: [PATCH] imapd segfaults after broken pipe)

Rob Siemborski rjs3 at andrew.cmu.edu
Mon Jan 6 16:05:17 EST 2003


On Mon, 6 Jan 2003, Henrique de Moraes Holschuh wrote:

> I suggest the assert in Gerd's patch to be moved to before the if clause.
> That way, we catch any other bug that triggers that assert.

Actually, based on discussions with Larry I'm pretty sure Gerd's patch is
now extra code that doesn't add much benefit (except for extra comparisons
in the "fast path"), so I'm probably going to just take it back out
(Sorry Gerd).  (since prot_flush is the only place it will really
matter... and that will catch the problem once we get there).

Thanks,
-Rob

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Rob Siemborski * Andrew Systems Group * Cyert Hall 207 * 412-268-7456
Research Systems Programmer * /usr/contributed Gatekeeper





More information about the Info-cyrus mailing list