<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 9/15/2017 9:10 AM, flowerysong wrote:<br>
<blockquote type="cite"
cite="mid:cyrusimap%2Fcyrus-sasl%2Fcommit%2F2ea0649f5cafce4f0b597d82f7acca7721e96cc8%2F24326253@github.com">
<p>I'm not sure what the utility is to having a hard-coded default
install location that doesn't respect the setting from
--with-plugindir; it would seem better to me to change <a
href="https://github.com/cyrusimap/cyrus-sasl/blob/2ea0649f5cafce4f0b597d82f7acca7721e96cc8/plugins/Makefile.am#L66"
moz-do-not-send="true">https://github.com/cyrusimap/cyrus-sasl/blob/2ea0649f5cafce4f0b597d82f7acca7721e96cc8/plugins/Makefile.am#L66</a>
to set sasldir to the same value as plugindir. People who need
the current behaviour would be able to override sasldir with
e.g. <code>make sasldir=/usr/lib/sasl2</code> (an approach we
currently use to make sure they're installed to plugindir) but
it would be more difficult for people to end up with a broken
install.</p>
<p
style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
You are receiving this because you are subscribed to this
thread.<br>
Reply to this email directly, <a
href="https://github.com/cyrusimap/cyrus-sasl/commit/2ea0649f5cafce4f0b597d82f7acca7721e96cc8#commitcomment-24326253"
moz-do-not-send="true">view it on GitHub</a>, or <a
href="https://github.com/notifications/unsubscribe-auth/AWZUI8FNnnQBYCtKaDik6XMgWmrxhFkzks5siqExgaJpZM4PZMes"
moz-do-not-send="true">mute the thread</a>.<img alt=""
src="https://github.com/notifications/beacon/AWZUI4dys6ui1hV4A346EKykCoGAZmLFks5siqExgaJpZM4PZMes.gif"
moz-do-not-send="true" height="1" width="1"></p>
<div itemscope="" itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope=""
itemtype="http://schema.org/ViewAction">
<link itemprop="url"
href="https://github.com/cyrusimap/cyrus-sasl/commit/2ea0649f5cafce4f0b597d82f7acca7721e96cc8#commitcomment-24326253">
<meta itemprop="name" content="View Commit">
</div>
<meta itemprop="description" content="View this Commit on
GitHub">
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/cyrusimap/cyrus-sasl","title":"cyrusimap/cyrus-sasl","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/cyrusimap/cyrus-sasl"}},"updates":{"snippets":[{"icon":"PERSON","message":"@flowerysong on 2ea0649: I'm not sure what the utility is to having a hard-coded default install location that doesn't respect the setting from --with-plugindir; it would seem better to me to change https://github.com/cyrusimap/cyrus-sasl/blob/2ea0649f5cafce4f0b597d82f7acca7721e96cc8/plugins/Makefile.am#L66 to set sasldir to the same value as plugindir. People who need the current behaviour would be able to override sasldir with e.g. `make sasldir=/usr/lib/sasl2` (an approach we currently use to make sure they're installed to plugindir) but it would be more difficult for people to end up with a broken install."}],"action":{"name":"View Commit","url":"https://github.com/cyrusimap/cyrus-sasl/commit/2ea0649f5cafce4f0b597d82f7acca7721e96cc8#commitcomment-24326253"}}}</script>
</blockquote>
<br>
<p>For me, that is the issue....I need sasldir and plugindir to
match, but there is no way to set sasldir, so I had to patch it to
be settable.</p>
<p>My patch also checks that the 2 match, INSTEAD of comparing to
something hard-coded. Having them match anyway would fix that.</p>
<p>- @if test "$(plugindir)" != "$(prefix)/lib/sasl2"; then \<br>
+ @if [ "X$(sasldir)" != "X$(plugindir)" ] ; then \<br>
</p>
<p>Here's what I do in Makefile after patching:</p>
<p>SASL2.32 = $(USRLIBDIR)/sasl2<br>
SASL2.64 = $(USRLIBDIR)/sasl2/$(MACH64)<br>
</p>
<p>CONFIGURE_OPTIONS.32 += --with-plugindir=$(SASL2.32)<br>
CONFIGURE_OPTIONS.64 += --with-plugindir=$(SASL2.64)<br>
CONFIGURE_OPTIONS.32 += --with-sasldir=$(SASL2.32)<br>
CONFIGURE_OPTIONS.64 += --with-sasldir=$(SASL2.64)<br>
</p>
<p>That's a lot of trouble to go to just to get them to install and
be looked for in the same place.<br>
</p>
<p><br>
</p>
<pre class="moz-signature" cols="72">--
Jan Parcel, Software Developer
Oracle Systems Server & Cloud Engineering</pre>
</body>
</html>