<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 26, 2015 at 11:21 AM, Howard Chu <span dir="ltr"><<a href="mailto:hyc@highlandsun.com" target="_blank">hyc@highlandsun.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Ignacio Casal wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Also, I made some fixes to the mdb backend to rename it to lmdb and to use the<br>
renamed library lmdb instead of mdb (since it seems to have changed upstream)<br>
See: <a href="https://github.com/nice-software/cyrus-sasl/commits/wip/lmdb" rel="noreferrer" target="_blank">https://github.com/nice-software/cyrus-sasl/commits/wip/lmdb</a><br>
</blockquote>
<br></span>
Patch looks OK.<span class=""><br></span></blockquote><div><br></div><div>Thanks for the review.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
As a plus I also modified the nmake stuff to allow to build the lmdb backend<br>
instead of libdb. This is still not quite well tested but some comment are<br>
welcomed.<br>
<a href="https://github.com/nice-software/cyrus-sasl/commit/d0cc4dfe20e71aef853a7f73f6228d1a268b2845" rel="noreferrer" target="_blank">https://github.com/nice-software/cyrus-sasl/commit/d0cc4dfe20e71aef853a7f73f6228d1a268b2845</a><br>
<br>
From another side, the lmdb maintainer is not interested on supporting MSVC<br>
builds, even though I made a fork in case somebody wants to give it a try:<br>
<a href="https://github.com/nice-software/lmdb/tree/wip/msvc" rel="noreferrer" target="_blank">https://github.com/nice-software/lmdb/tree/wip/msvc</a><br>
<br>
At this point a question arises, should we support a backend that we cannot<br>
build on the platforms supported by cyrus-sasl? That is, should we drop lmdb<br>
since the maintainer is not interested on it? Also we have the code that is<br>
not building at all without the patches I pointed out.<br>
</blockquote>
<br></span>
Seems like a silly question, since LMDB builds and runs perfectly well on all platforms.<br>
<br>
We simply choose not to support the Microsoft IDE.<span class="HOEnZb"><font color="#888888"><br></font></span></blockquote><div><br></div><div>It is not a silly question when the supported microsoft build for cyrus sasl is msvc :)<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888">
<br>
-- <br>
-- Howard Chu<br>
CTO, Symas Corp. <a href="http://www.symas.com" rel="noreferrer" target="_blank">http://www.symas.com</a><br>
Director, Highland Sun <a href="http://highlandsun.com/hyc/" rel="noreferrer" target="_blank">http://highlandsun.com/hyc/</a><br>
Chief Architect, OpenLDAP <a href="http://www.openldap.org/project/" rel="noreferrer" target="_blank">http://www.openldap.org/project/</a><br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr"><div>Ignacio Casal Quinteiro<br></div></div></div>
</div></div>