<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi,</p>
<p>With your patch, my reproducer don't work anymore. Thank you very
much!<br>
</p>
<p>I'll do more testing though and tell if I find new fail case.</p>
<p>Anthony<br>
</p>
<br>
<div class="moz-cite-prefix">On 07/27/2018 08:24 AM, Bron Gondwana
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:aeefddcf-6fb5-47b4-9013-0ded34c981c6@sloti22d1t06">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
<div style="font-family:Arial;">Hi Nic,<br>
</div>
<div style="font-family:Arial;"><br>
</div>
<div style="font-family:Arial;">Damn! That interface is really
frustrating in terms of inability to debug. One possible
culprit in all this is
b56e391c9579b3c4c9fd6e64fa29e627ec358339. I've just copied that
back to 3.0 asc665af571dc1f9d870d53f2aa4ea29bb5cd52738 . Are
you able to try with that added?</div>
<div style="font-family:Arial;"><br>
</div>
<div style="font-family:Arial;">Cheers,<br>
</div>
<div style="font-family:Arial;"><br>
</div>
<div style="font-family:Arial;">Bron.<br>
</div>
<div style="font-family:Arial;"><br>
</div>
<div style="font-family:Arial;"><br>
</div>
<div style="font-family:Arial;">On Fri, Jul 27, 2018, at 06:02,
Nic Bernstein wrote:<br>
</div>
<blockquote type="cite" id="fastmail-quoted">
<div style="font-family:Arial;">Bron,<br>
</div>
<div style="font-family:Arial;"> Answering my own question, I
now see that the fix you refer to is in <span
class="fastmail-quoted-sha-block"><span
class="fastmail-quoted-sha
fastmail-quoted-user-select-contain">cfb3054,
imap/mailbox.c on 1/2/2017, which is in both master and
3.0... However, I've still got the problem, so same
failed assertion, but different bug?<br>
-nic<br>
</span></span></div>
<div style="font-family:Arial;"> <br>
</div>
<div class="fastmail-quoted-moz-cite-prefix">On 07/24/2018 12:10
PM, Nic Bernstein wrote:<br>
</div>
<blockquote
cite="mid:b8988913-8602-540b-b01c-0e9bf14f37f6@onlight.com"
type="cite">
<div style="font-family:Arial;">Bron, et al.,<br>
</div>
<div style="font-family:Arial;"> Was this change ever
cherry-picked to 3.0? I am seeing the same issue with
recent 3.0 HEAD, but slightly different location:<br>
</div>
<div style="font-family:Arial;"> <br>
</div>
<blockquote>
<div style="font-family:Arial;">user.masked: updating
sync_crc 521983118 => 503807715<br>
</div>
<div style="font-family:Arial;"> fatal error: Internal
error: assertion failed: imap/message.c: 4286:
!message_need(m, M_RECORD)<br>
</div>
</blockquote>
<div style="font-family:Arial;">A git log of imap/message.c
doesn't show a commit from 1/2/2017, and nothing affecting
imap/message.c around that time seems to line up with this.<br>
</div>
<div style="font-family:Arial;"> <br>
</div>
<div style="font-family:Arial;"> Please advise,<br>
</div>
<div style="font-family:Arial;"> -nic<br>
</div>
<div style="font-family:Arial;"> <br>
</div>
<div style="font-family:Arial;"> <br>
</div>
<div class="fastmail-quoted-moz-cite-prefix">On 01/02/2017
07:13 AM, Bron Gondwana via Cyrus-devel wrote:<br>
</div>
<blockquote
cite="mid:1483362793.2061068.834933537.7E80E6A9@webmail.messagingengine.com"
type="cite">
<div style="font-family:Arial;">Thanks for the data. It was
8 bytes of zeros across a UID and INTERNALDATE in the
cyrus.index file.<br>
</div>
<div style="font-family:Arial;"><br>
</div>
<div style="font-family:Arial;">I now have a fixed
reconstruct which can detect and repair this rather than
aborting, pushed to master.<br>
</div>
<div style="font-family:Arial;">I also have a Cassandane
testcase for this and a couple of other things that
reconstruct does :)<br>
</div>
<div style="font-family:Arial;"><br>
</div>
<div style="font-family:Arial;">Bron.<br>
</div>
<div><br>
</div>
<div>On Thu, 29 Dec 2016, at 09:45, Bron Gondwana via
Cyrus-devel wrote:<br>
</div>
<blockquote type="cite">
<div style="font-family:Arial;">Wow, interesting. Are you
willing to send me a tarball containing the spool folder
including cyrus.index and cyrus.cache files as well as
the email files themselves? I'll need your imapd.conf
file as well :)<br>
</div>
<div style="font-family:Arial;"><br>
</div>
<div style="font-family:Arial;">Cheers,<br>
</div>
<div style="font-family:Arial;"><br>
</div>
<div style="font-family:Arial;">Bron.<br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>On Thu, 29 Dec 2016, at 00:28, Thomas Cataldo via
Cyrus-devel wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div style="font-family:Arial;">Hi,<br>
</div>
<div><br>
</div>
<div>Running a build of 3.0.0-beta6 I hit the
following assertion on one of my test mailboxes
after playing a bit with the replication stuff :<br>
</div>
<div><br>
</div>
<div>
<p><span>root@bm1604:~#
/usr/lib/cyrus/sbin/sync_client -n eclipse -o -u
<a href="mailto:tom@ex2016.vmw"
class="fastmail-quoted-moz-txt-link-abbreviated"
moz-do-not-send="true">tom@ex2016.vmw</a></span><br>
</p>
<p><span>Fatal error: Internal error: assertion
failed: imap/message.c: 4246: !message_need(m,
M_RECORD)</span><br>
</p>
<p><span>root@bm1604:~# cyradm -u admin0 localhost</span><br>
</p>
<p><span>Password: </span><br>
</p>
<p><span>localhost> version</span><br>
</p>
<p><span>name : Cyrus IMAPD</span><br>
</p>
<p><span>version : 3.0.0-beta6-3-gf721e5b</span><br>
</p>
<p><span>vendor : Project Cyrus</span><br>
</p>
<p><span>support-url: <a
href="http://www.cyrusimap.org"
moz-do-not-send="true">http://www.cyrusimap.org</a></span><br>
</p>
<p><span>os : Linux</span><br>
</p>
<p><span>os-version : 4.4.0-57-generic</span><br>
</p>
<p><span>environment: Built w/Cyrus SASL 2.1.26</span><br>
</p>
<p><span> Running w/Cyrus SASL 2.1.26</span><br>
</p>
<p><span> Built w/OpenSSL 1.0.2g 1 Mar
2016</span><br>
</p>
<p><span> Running w/OpenSSL 1.0.2g 1
Mar 2016</span><br>
</p>
<p><span> Built w/zlib 1.2.8</span><br>
</p>
<p><span> Running w/zlib 1.2.8</span><br>
</p>
<p><span> CMU Sieve 2.4</span><br>
</p>
<p><span> mmap = shared</span><br>
</p>
<p><span> lock = fcntl</span><br>
</p>
<p><span> nonblock = ioctl</span><br>
</p>
<p><span> idle = idled</span><br>
</p>
<p><br>
</p>
<p>root@bm1604:~# telnet localhost 1143<br>
</p>
<p>Connected to localhost.<br>
</p>
<p><span>Escape character is '^]'.</span><br>
</p>
<p><span>* OK [CAPABILITY IMAP4rev1 LITERAL+ ID
ENABLE STARTTLS AUTH=PLAIN SASL-IR] server ready</span><br>
</p>
<p><span>. login <a href="mailto:tom@ex2016.vmw"
class="fastmail-quoted-moz-txt-link-abbreviated"
moz-do-not-send="true">tom@ex2016.vmw</a>
xxxxxx</span><br>
</p>
<p><span>. OK [CAPABILITY IMAP4rev1 LITERAL+ ID
ENABLE ACL RIGHTS=kxten QUOTA MAILBOX-REFERRALS
NAMESPACE UIDPLUS NO_ATOMIC_RENAME UNSELECT
CHILDREN MULTIAPPEND BINARY CATENATE CONDSTORE
ESEARCH SEARCH=FUZZY SORT SORT=MODSEQ
SORT=DISPLAY SORT=UID THREAD=ORDEREDSUBJECT
THREAD=REFERENCES THREAD=REFS ANNOTATEMORE
ANNOTATE-EXPERIMENT-1 METADATA LIST-EXTENDED
LIST-STATUS LIST-MYRIGHTS LIST-METADATA WITHIN
QRESYNC SCAN XLIST XMOVE MOVE SPECIAL-USE
CREATE-SPECIAL-USE DIGEST=SHA1 X-REPLICATION
URLAUTH URLAUTH=BINARY LOGINDISABLED
COMPRESS=DEFLATE X-QUOTA=STORAGE X-QUOTA=MESSAGE
X-QUOTA=X-ANNOTATION-STORAGE
X-QUOTA=X-NUM-FOLDERS IDLE] User logged in
SESSIONID=<cyrus-43098-1482931179-1-18150325414286070410></span><br>
</p>
<p><span>. select inbox</span><br>
</p>
<p><span>* BYE Fatal error: Internal error:
assertion failed: imap/message.c: 4246:
!message_need(m, M_RECORD)</span><br>
</p>
<p><span>Connection closed by foreign host.</span><br>
</p>
<p><span></span><br>
</p>
<p><span>Trying to reconstruct the mailbox does not
help :</span><br>
</p>
<p><span>root@bm1604:~#
/usr/lib/cyrus/sbin/reconstruct -rfxGROU <a
href="mailto:tom@ex2016.vmw"
class="fastmail-quoted-moz-txt-link-abbreviated"
moz-do-not-send="true">tom@ex2016.vmw</a></span><br>
</p>
<p><span><a href="mailto:tom@ex2016.vmw"
class="fastmail-quoted-moz-txt-link-abbreviated"
moz-do-not-send="true">tom@ex2016.vmw</a></span><br>
</p>
<p>The error is still here after that.<br>
</p>
<p>Any idea ?<br>
</p>
<p>Regards,<br>
</p>
<p>Thomas.<br>
</p>
<p><br>
</p>
</div>
</div>
</blockquote>
<div style="font-family:Arial;"><br>
</div>
<div>
<div>--<br>
</div>
<div> Bron Gondwana<br>
</div>
<div> <a href="mailto:brong@fastmail.fm"
class="fastmail-quoted-moz-txt-link-abbreviated"
moz-do-not-send="true">brong@fastmail.fm</a><br>
</div>
<div><br>
</div>
</div>
<div style="font-family:Arial;"><br>
</div>
</blockquote>
<div style="font-family:Arial;"><br>
</div>
<div id="fastmail-quoted-sig567075">
<div class="fastmail-quoted-signature">--<br>
</div>
<div class="fastmail-quoted-signature"> Bron Gondwana<br>
</div>
<div class="fastmail-quoted-signature"> <a
href="mailto:brong@fastmail.fm"
class="fastmail-quoted-moz-txt-link-abbreviated"
moz-do-not-send="true">brong@fastmail.fm</a><br>
</div>
<div class="fastmail-quoted-signature"><br>
</div>
</div>
<div style="font-family:Arial;"><br>
</div>
</blockquote>
<div style="font-family:Arial;"><br>
</div>
<pre cols="72" class="fastmail-quoted-moz-signature">--
Nic Bernstein <a href="mailto:nic@onlight.com" class="fastmail-quoted-moz-txt-link-abbreviated" moz-do-not-send="true">nic@onlight.com</a>
Onlight, Inc. <a href="http://www.onlight.com" class="fastmail-quoted-moz-txt-link-abbreviated" moz-do-not-send="true">www.onlight.com</a>
6525 W Bluemound Road, Suite 24 v. 414.272.4477
Milwaukee, Wisconsin 53213-4073
</pre>
</blockquote>
<div style="font-family:Arial;"><br>
</div>
<pre cols="72" class="fastmail-quoted-moz-signature">--
Nic Bernstein <a href="mailto:nic@onlight.com" class="fastmail-quoted-moz-txt-link-abbreviated" moz-do-not-send="true">nic@onlight.com</a>
Onlight, Inc. <a href="http://www.onlight.com" class="fastmail-quoted-moz-txt-link-abbreviated" moz-do-not-send="true">www.onlight.com</a>
6525 W Bluemound Road, Suite 24 v. 414.272.4477
Milwaukee, Wisconsin 53213-4073
</pre>
</blockquote>
<div style="font-family:Arial;"><br>
</div>
<div id="sig56629417">
<div class="signature">--<br>
</div>
<div class="signature"> Bron Gondwana, CEO, FastMail Pty Ltd<br>
</div>
<div class="signature"> <a class="moz-txt-link-abbreviated"
href="mailto:brong@fastmailteam.com">brong@fastmailteam.com</a><br>
</div>
<div class="signature"><br>
</div>
</div>
<div style="font-family:Arial;"><br>
</div>
</blockquote>
<br>
</body>
</html>