<!DOCTYPE html>
<html>
<head>
<title></title>
</head>
<body><div style="font-family:Arial;">There were a couple of nits around style:<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">+ int remove_temp_spool_file = 0 ;<br></div>
<div style="font-family:Arial;">+ int object_storage_enabled = 0 ;<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">(we don't put a space before the ; anywhere in the rest of the codebase)<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">And some <br></div>
<div style="font-family:Arial;">}<br></div>
<div style="font-family:Arial;">else<br></div>
<div style="font-family:Arial;">{<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">or<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">if (condition)<br></div>
<div style="font-family:Arial;">{<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">We cuddle the brace like this:<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">}<br></div>
<div style="font-family:Arial;">else {<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">if (condition) {<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">Pretty much exclusively. But those can be fixed easily enough. The important thing for me was to check that the non-object storage paths are the same, and they read identically to me.<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">I've done a build and Cassandane test run, and I'm happy with it. Pushing a merge of that branch to master now. Sorry about taking so long to get to this.<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">Meeting in just under 2 hours, might see you there :)<br></div>
<div> </div>
<div style="font-family:Arial;">Bron.<br></div>
<div> </div>
<div>On Wed, Feb 24, 2016, at 01:39, Raymond Poitras wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div style="font-family:Arial;">Hi Bron<br></div>
<div> </div>
<div>Sorry for the delay and thank you for pushing this work to master.<br></div>
<div> </div>
<div>A) While doing this, some of the logic was broken. (This is now fix.)<br></div>
<div>B) The new solution works very well with a mix of archive (in object storage) and non archive (on regular spool) emails.<br></div>
<div>C) Unarchive have been fix. (was used previously to remove email from object storage. Now a new function is used for that).<br></div>
<div>D) Include reconstruct support. Works very well if message.db file is reliable.<br></div>
<div> </div>
<div>Please let me know if you can update master again from here <a href="https://github.com/RaymondPo/cyrus-imapd/tree/Cyrus-OpenIO">https://github.com/RaymondPo/cyrus-imapd/tree/Cyrus-OpenIO</a><br></div>
<div> </div>
<div>When is the next meeting? Jean-Francois and I would like to attend<br></div>
<div> </div>
<div>Regards<br></div>
<div>Raymond<br></div>
<div> </div>
</div>
<div><div style="font-family:Arial;"> </div>
<div><div style="font-family:Arial;">2015-10-13 8:03 GMT-04:00 Bron Gondwana <span dir="ltr"><<a href="mailto:brong@fastmail.fm">brong@fastmail.fm</a>></span>:<br></div>
<blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204, 204, 204);padding-left:1ex;"><div style="font-family:Arial;">I've pushed the objectstorage code based on Raymond and Jean-Francois's work to master. It's almost exactly what was on Raymond's branch with just a couple of modifications.<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">
1) updated for some API changes I'd made to archiving in append.c<br></div>
<div style="font-family:Arial;">
2) fixed compilation under warn-unused-variables<br></div>
<div style="font-family:Arial;">
3) normalised logic between append_fromstage and append_copy for handling objectstorage errors by creating non-ARCHIVED files.<br></div>
<div style="font-family:Arial;">
4) fixed file copy in mailbox_archive to work the same way as the file moves, where it correctly passes the source/destination file to objectstorage and gets the file back, so unarchive works.<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">
WARNING WARNING WARNING: while I've tested that normal operation and normal archive file operation (non-objectstorage) works correctly with Cassandane and FastMail experimental branch, I haven't done more than rudimentary testing with the dummy objectstorage.<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">
I'm almost positive that reconstruct won't work correctly with object storage turned on right now.<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">
This is still very much work in progress - but putting it on master means that the code will be maintained and updated as other API changes are made.<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">
Thanks Raymond and Jean-Francois for all your work on this. I hope it gets more testing and use.<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">
Cheers,<br></div>
<div style="font-family:Arial;"> </div>
<div style="font-family:Arial;">
Bron.<br></div>
<div style="font-family:Arial;">
<span><span style="color:rgb(136, 136, 136)" class="colour"><br>
--<br>
Bron Gondwana<br>
<a href="mailto:brong@fastmail.fm">brong@fastmail.fm</a></span></span></div>
</blockquote></div>
</div>
</blockquote><div style="font-family:Arial;"> </div>
<div id="sig567075"><div class="signature">-- <br></div>
<div class="signature"> Bron Gondwana<br></div>
<div class="signature"> brong@fastmail.fm<br></div>
<div class="signature"> </div>
</div>
<div style="font-family:Arial;"> </div>
</body>
</html>