From murch at andrew.cmu.edu Thu Jul 23 14:43:49 2009 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Thu, 23 Jul 2009 14:43:49 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200907231843.n6NIhnGB024264@unix32.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix32.andrew.cmu.edu:/var/tmp/cvs-serv24258 Modified Files: imap_proxy.c Log Message: make sure servername isn't empty, and log which server we're trying --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/imap_proxy.c.diff?r1=1.15&r2=1.16 From murch at andrew.cmu.edu Fri Jul 24 11:15:43 2009 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Fri, 24 Jul 2009 11:15:43 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200907241515.n6OFFhwA010274@unix33.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix33.andrew.cmu.edu:/var/tmp/cvs-serv10269 Modified Files: imap_proxy.c Log Message: can't try to duplicate a string after we've freed it --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/imap_proxy.c.diff?r1=1.16&r2=1.17 From brong at andrew.cmu.edu Mon Jul 27 22:45:44 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Mon, 27 Jul 2009 22:45:44 EDT Subject: [Cyrus-CVS] src/cyrus/imap by brong Message-ID: <200907280245.n6S2jiPI006614@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/imap In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/imap Modified Files: sync_server.c Log Message: Don't log sync "Unlocked" events at INFO level It's quite noisy and useless in the logs. Still send it at "DEBUG" level in case you need it for something... --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/sync_server.c.diff?r1=1.30&r2=1.31 From brong at andrew.cmu.edu Mon Jul 27 22:46:23 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Mon, 27 Jul 2009 22:46:23 EDT Subject: [Cyrus-CVS] src/cyrus/imap by brong Message-ID: <200907280246.n6S2kN8D006637@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/imap In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/imap Modified Files: mboxlist.c Log Message: Check that we have an mupdate_server Otherwise the partition check code breaks every non-murder site in the world! (I'm not convinced that this is 100% correct either, but at least it restricts the issue to sites that have murder enabled) --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mboxlist.c.diff?r1=1.269&r2=1.270 From brong at andrew.cmu.edu Mon Jul 27 22:47:00 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Mon, 27 Jul 2009 22:47:00 EDT Subject: [Cyrus-CVS] src/cyrus/lib by brong Message-ID: <200907280247.n6S2l0oV006659@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/lib In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/lib Modified Files: cyrusdb_skiplist.c Log Message: Use correctly sized variable for recovery time Global Recovery was being htonl'd into a time_t, which is a 64 bit value on some platforms. Depending on the host bit order, this might be promoted into the last 4 bytes of an 8 bit value, meaning that the bytes written to disk were actually all zero. Change it to a bit32 and give it a more descriptive name. Thanks to Michael Bacon for finding the bug. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/cyrusdb_skiplist.c.diff?r1=1.66&r2=1.67 From brong at andrew.cmu.edu Mon Jul 27 22:47:28 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Mon, 27 Jul 2009 22:47:28 EDT Subject: [Cyrus-CVS] src/cyrus/lib by brong Message-ID: <200907280247.n6S2lSOx006681@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/lib In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/lib Modified Files: cyrusdb_skiplist.c Log Message: Handle skiplist foreach early exit If a foreach callback returns a non-zero response, it exits early. In the case where this is in a non-transactional foreach, this caused an attempt to unlock an already unlocked database. Keep a flag that shows if we need the unlock to make it really clear. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/cyrusdb_skiplist.c.diff?r1=1.67&r2=1.68 From brong at andrew.cmu.edu Mon Jul 27 22:48:18 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Mon, 27 Jul 2009 22:48:18 EDT Subject: [Cyrus-CVS] src/cyrus/lib by brong Message-ID: <200907280248.n6S2mIGv006703@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/lib In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/lib Modified Files: cyrusdb_skiplist.c Log Message: Use uint32_t in skiplist Use the standard type rather than defining our own "bit32". --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/cyrusdb_skiplist.c.diff?r1=1.68&r2=1.69 From brong at andrew.cmu.edu Mon Jul 27 22:48:49 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Mon, 27 Jul 2009 22:48:49 EDT Subject: [Cyrus-CVS] src/cyrus/imap by brong Message-ID: <200907280248.n6S2mnKP006726@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/imap In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/imap Modified Files: imapd.c Log Message: Log mailbox events if condstore is enabled and flags change --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/imapd.c.diff?r1=1.565&r2=1.566 From brong at andrew.cmu.edu Mon Jul 27 22:50:54 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Mon, 27 Jul 2009 22:50:54 EDT Subject: [Cyrus-CVS] src/cyrus/imap by brong Message-ID: <200907280250.n6S2oscM006753@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/imap In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/imap Modified Files: idled.c Log Message: Fork idled before cyrus_init() We were getting: * DBERROR db4: environment reference count went negative Reliably in one random process when shutting down our cyrus instances, and this is even with no BDB databases defined in our config. The cause was tracked to idled calling cyrus_done in both the parent and child processes, but cyrus_init only in the parent, hence closing the environment twice. It's possible this also caused other issues for BDB, since it's invalid usage of the API. This change moves the fork to before cyrus_init(), meaning that the environment is only ever initialised in the child process. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/idled.c.diff?r1=1.26&r2=1.27 From brong at andrew.cmu.edu Tue Jul 28 02:17:26 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Tue, 28 Jul 2009 02:17:26 EDT Subject: [Cyrus-CVS] src/cyrus/imap by brong Message-ID: <200907280617.n6S6HQwX007232@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/imap In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/imap Modified Files: mboxname.c Log Message: Detected "deleted" heirarchy even if turned off Even if you don't have delayed delete enabled, this namespace is reserved. This way is much safer, we know it's a "deleted" namespace regardless. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mboxname.c.diff?r1=1.46&r2=1.47 From murch at andrew.cmu.edu Wed Jul 29 11:51:23 2009 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Wed, 29 Jul 2009 11:51:23 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200907291551.n6TFpNYN010121@unix11.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix11.andrew.cmu.edu:/var/tmp/cvs-serv10116 Modified Files: imapd.c Log Message: Allow frontends to proxy SETQUOTA/GETQUOTA commands. This simplifies the CMU IDM code --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/imapd.c.diff?r1=1.566&r2=1.567