From brong at andrew.cmu.edu Fri Aug 28 09:45:47 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Fri, 28 Aug 2009 09:45:47 EDT Subject: [Cyrus-CVS] src/cyrus/imap by brong Message-ID: <200908281345.n7SDjl3h013454@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/imap In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/imap Modified Files: index.c Log Message: Don't process "expunged" if uidvalidity changed We had a process crash during index_check, and further examination showed that "oldexists" was -1 due to a UID validity change (the user had been deleted and then another user renamed into place within about 30 seconds, while an authenticated imap connection was held open) This patch skips the "expunged" check if the uidvalidity has changed, since expunged doesn't make sense if you don't have the same uidvalidity. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/index.c.diff?r1=1.251&r2=1.252 From brong at andrew.cmu.edu Fri Aug 28 09:47:10 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Fri, 28 Aug 2009 09:47:10 EDT Subject: [Cyrus-CVS] src/cyrus/imap by brong Message-ID: <200908281347.n7SDlAn5013477@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/imap In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/imap Modified Files: mailbox.c Log Message: Early and strict version check of index header --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mailbox.c.diff?r1=1.193&r2=1.194 From brong at andrew.cmu.edu Fri Aug 28 09:48:46 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Fri, 28 Aug 2009 09:48:46 EDT Subject: [Cyrus-CVS] src/cyrus/imap by brong Message-ID: <200908281348.n7SDmknR013500@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/imap In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/imap Modified Files: index.c index.h mailbox.c mailbox.h make_md5.c make_sha1.c mbexamine.c sync_server.c unexpunge.c Log Message: Rewrite mailbox_cache_size to populate a pointer structure The code is littered with CACHE_ITEM_NEXT calls. Very annoyingly, these can wind up jumping to random addresses outside the mmaped space, and there's no way of knowing if they're valid or not. This patch changes this apart from some sync code, by creating a struct cacheitem and a datastructure of 10 of those: cacherecord. You call cache_parserecord (or the mailbox_* functions that do the same for a specific msgno/offset) to get the cache items into the data structure, then use them by enum name. Also - cache_parserecord returns the length of the entire cache --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/index.c.diff?r1=1.252&r2=1.253 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/index.h.diff?r1=1.16&r2=1.17 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mailbox.c.diff?r1=1.194&r2=1.195 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mailbox.h.diff?r1=1.94&r2=1.95 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/make_md5.c.diff?r1=1.9&r2=1.10 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/make_sha1.c.diff?r1=1.5&r2=1.6 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mbexamine.c.diff?r1=1.20&r2=1.21 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/sync_server.c.diff?r1=1.31&r2=1.32 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/unexpunge.c.diff?r1=1.12&r2=1.13 From brong at andrew.cmu.edu Fri Aug 28 09:53:25 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Fri, 28 Aug 2009 09:53:25 EDT Subject: [Cyrus-CVS] src/cyrus/imap by brong Message-ID: <200908281353.n7SDrPMf013587@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/imap In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/imap Modified Files: mbdump.c mbexamine.c Log Message: Use index record parsing functions instead of direct access macros --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mbdump.c.diff?r1=1.44&r2=1.45 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mbexamine.c.diff?r1=1.21&r2=1.22 From brong at andrew.cmu.edu Fri Aug 28 09:54:13 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Fri, 28 Aug 2009 09:54:13 EDT Subject: [Cyrus-CVS] src/cyrus/imap by brong Message-ID: <200908281354.n7SDsDMu013614@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/imap In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/imap Modified Files: search_engines.c Log Message: Squatter - don't abort just because one search term is short --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/search_engines.c.diff?r1=1.10&r2=1.11 From brong at andrew.cmu.edu Fri Aug 28 10:06:04 2009 From: brong at andrew.cmu.edu (brong at andrew.cmu.edu) Date: Fri, 28 Aug 2009 10:06:04 EDT Subject: [Cyrus-CVS] src/cyrus/imap by brong Message-ID: <200908281406.n7SE64GQ018163@cyrus-devel-01.andrew.cmu.edu> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/imap In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/imap Modified Files: index.c Log Message: Fix "msgid" extra line leak from FastMail auditlog patch --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/index.c.diff?r1=1.253&r2=1.254