From wescraig at andrew.cmu.edu Thu Sep 4 16:44:08 2008 From: wescraig at andrew.cmu.edu (wescraig at andrew.cmu.edu) Date: Thu, 04 Sep 2008 16:44:08 EDT Subject: [Cyrus-CVS] src/cyrus/ptclient by wescraig Message-ID: <200809042044.m84Ki8O3012155@unix13.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/ptclient In directory unix13.andrew.cmu.edu:/var/tmp/cvs-serv12121 Modified Files: ptloader.c Log Message: ptloader's reply string should be null terminated keyinhex is not initialized or ever used --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/ptclient/ptloader.c.diff?r1=1.48&r2=1.49 From murch at andrew.cmu.edu Fri Sep 5 11:56:21 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Fri, 05 Sep 2008 11:56:21 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809051556.m85FuLhU006289@unix11.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix11.andrew.cmu.edu:/var/tmp/cvs-serv6280 Modified Files: imapd.c Log Message: squash compiler warning --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/imapd.c.diff?r1=1.550&r2=1.551 From murch at andrew.cmu.edu Tue Sep 9 11:28:25 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 09 Sep 2008 11:28:25 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809091528.m89FSPI7007018@unix37.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix37.andrew.cmu.edu:/var/tmp/cvs-serv7008 Modified Files: .cvsignore Makefile.in Added Files: cyr_virusscan.c Log Message: initial version of cyr_virusscan currently only works with libclamav. need to add autoconf foo to detect antivirus libraries. need to add code to append a notification message to user's INBOX --- links to diffs follow --- ADDED http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/cyr_virusscan.c http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/.cvsignore.diff?r1=1.14&r2=1.15 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/Makefile.in.diff?r1=1.194&r2=1.195 From murch at andrew.cmu.edu Wed Sep 10 10:40:51 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Wed, 10 Sep 2008 10:40:51 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809101440.m8AEepuf005051@unix24.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix24.andrew.cmu.edu:/var/tmp/cvs-serv5046 Modified Files: cyr_virusscan.c Log Message: refactored code to make it easier to add support for different virus scanning libraries --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/cyr_virusscan.c.diff?r1=1.1&r2=1.2 From murch at andrew.cmu.edu Wed Sep 10 11:30:02 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Wed, 10 Sep 2008 11:30:02 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809101530.m8AFU287006809@unix14.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix14.andrew.cmu.edu:/var/tmp/cvs-serv6804 Modified Files: cyr_virusscan.c Log Message: nits --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/cyr_virusscan.c.diff?r1=1.2&r2=1.3 From murch at andrew.cmu.edu Wed Sep 10 11:38:17 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Wed, 10 Sep 2008 11:38:17 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809101538.m8AFcHY2006325@unix13.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix13.andrew.cmu.edu:/var/tmp/cvs-serv6320 Modified Files: cyr_virusscan.c Log Message: more nits --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/cyr_virusscan.c.diff?r1=1.3&r2=1.4 From wescraig at andrew.cmu.edu Thu Sep 18 21:03:20 2008 From: wescraig at andrew.cmu.edu (wescraig at andrew.cmu.edu) Date: Thu, 18 Sep 2008 21:03:20 EDT Subject: [Cyrus-CVS] src/cyrus/imap by wescraig Message-ID: <200809190103.m8J13L2o031344@unix32.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix32.andrew.cmu.edu:/var/tmp/cvs-serv31339 Modified Files: mbexamine.c Log Message: Per John Capo: anything that uses strings from the cache file must use the length and not depend on NULL terminated strings --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mbexamine.c.diff?r1=1.19&r2=1.20 From murch at andrew.cmu.edu Fri Sep 19 13:10:51 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Fri, 19 Sep 2008 13:10:51 EDT Subject: [Cyrus-CVS] src/cyrus/lib by murch Message-ID: <200809191710.m8JHAp47006642@unix13.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/lib In directory unix13.andrew.cmu.edu:/var/tmp/cvs-serv6636 Modified Files: cyrusdb_quotalegacy.c Log Message: rewrite foreach() to use readir() instead of glob() this avoids problems with glibc/Heimdal glob() clashes --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/cyrusdb_quotalegacy.c.diff?r1=1.18&r2=1.19 From murch at andrew.cmu.edu Mon Sep 22 08:58:35 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Mon, 22 Sep 2008 08:58:35 EDT Subject: [Cyrus-CVS] src/cyrus/lib by murch Message-ID: <200809221258.m8MCwZmi003991@unix24.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/lib In directory unix24.andrew.cmu.edu:/var/tmp/cvs-serv3986 Modified Files: imapurl.c Log Message: fix a potential buffer overflow (Bron Gondwana ) --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/imapurl.c.diff?r1=1.15&r2=1.16 From murch at andrew.cmu.edu Tue Sep 23 12:17:09 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 23 Sep 2008 12:17:09 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809231617.m8NGH92S005462@unix36.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix36.andrew.cmu.edu:/var/tmp/cvs-serv5457 Modified Files: Makefile.in cyr_virusscan.c Log Message: aded code to append a notification message to user's INBOX when we remove infected messages from any of their mailboxes --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/Makefile.in.diff?r1=1.195&r2=1.196 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/cyr_virusscan.c.diff?r1=1.4&r2=1.5 From murch at andrew.cmu.edu Tue Sep 23 12:19:43 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 23 Sep 2008 12:19:43 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809231619.m8NGJh9L006433@unix12.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix12.andrew.cmu.edu:/var/tmp/cvs-serv6428 Modified Files: append.c Log Message: Always unlink files. >From Bron Gondwanda : I did an audit of the uses of "open" where a file might still exist from a previous crash and be hardlinked somewhere we care about. There was one more location. This patch just adds an unlink before the stage file gets created during append_newstage. It's trivial and boring, but makes me feel safer about the integrity of my possibly-hardlinked spool files! --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/append.c.diff?r1=1.114&r2=1.115 From murch at andrew.cmu.edu Tue Sep 23 12:28:15 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 23 Sep 2008 12:28:15 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809231628.m8NGSFGP006060@unix37.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix37.andrew.cmu.edu:/var/tmp/cvs-serv6023 Modified Files: mailbox.c sync_server.c Log Message: Check Cache Record Size >From Bron Gondwana : We had a problem on 64bit kernel machines where cache corruption caused multi-gigabyte core files to be generated because the huge bogus offsets caused massive mmaped areas. This patch checks that every cache record points to a location between cache_base and (cache_base + cache_size), and returns an IOERROR rather than crashing if it doesn't. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mailbox.c.diff?r1=1.179&r2=1.180 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/sync_server.c.diff?r1=1.25&r2=1.26 From murch at andrew.cmu.edu Tue Sep 23 12:39:18 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 23 Sep 2008 12:39:18 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809231639.m8NGdJ28006150@unix37.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix37.andrew.cmu.edu:/var/tmp/cvs-serv6145/imap Modified Files: cyr_dbtool.c Log Message: Skiplist safe unlock >From Bron Gondwana : This patch just adds unlocks within the myconsistent() function and adds an option to cyr_dbtool to check consistency. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/cyr_dbtool.c.diff?r1=1.5&r2=1.6 From murch at andrew.cmu.edu Tue Sep 23 12:39:19 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 23 Sep 2008 12:39:19 EDT Subject: [Cyrus-CVS] src/cyrus/lib by murch Message-ID: <200809231639.m8NGdJRH006156@unix37.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/lib In directory unix37.andrew.cmu.edu:/var/tmp/cvs-serv6145/lib Modified Files: cyrusdb_skiplist.c Log Message: Skiplist safe unlock >From Bron Gondwana : This patch just adds unlocks within the myconsistent() function and adds an option to cyr_dbtool to check consistency. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/cyrusdb_skiplist.c.diff?r1=1.61&r2=1.62 From murch at andrew.cmu.edu Tue Sep 23 12:39:19 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 23 Sep 2008 12:39:19 EDT Subject: [Cyrus-CVS] src/cyrus/man by murch Message-ID: <200809231639.m8NGdJiS006162@unix37.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/man In directory unix37.andrew.cmu.edu:/var/tmp/cvs-serv6145/man Modified Files: cyr_dbtool.8 Log Message: Skiplist safe unlock >From Bron Gondwana : This patch just adds unlocks within the myconsistent() function and adds an option to cyr_dbtool to check consistency. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/man/cyr_dbtool.8.diff?r1=1.3&r2=1.4 From murch at andrew.cmu.edu Tue Sep 23 13:34:37 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 23 Sep 2008 13:34:37 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809231734.m8NHYcOH007391@unix38.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix38.andrew.cmu.edu:/var/tmp/cvs-serv7376/imap Modified Files: imapparse.c sync_support.c Log Message: Make MAXWORD and MAXQUOTED configurable >From Bron Gondwana : We've been patching our Cyrus at FastMail to make MAXWORD and MAXQUOTED much bigger, from 32k to 512k. This patch is a rework of our patch doing the following: 1) create two new config options "maxword" and "maxquoted" 2) use these options rather than hard coded limits 3) set the defaults to a nice halfway point: 128k. This avoids the "I use Cyrus on an embedded machine with 10Mb memory" vs "I have a shiny new machine with 32Gb of memory" (we have 2 of them now :)) argument. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/imapparse.c.diff?r1=1.18&r2=1.19 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/sync_support.c.diff?r1=1.19&r2=1.20 From murch at andrew.cmu.edu Tue Sep 23 13:34:38 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 23 Sep 2008 13:34:38 EDT Subject: [Cyrus-CVS] src/cyrus/lib by murch Message-ID: <200809231734.m8NHYcg9007397@unix38.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/lib In directory unix38.andrew.cmu.edu:/var/tmp/cvs-serv7376/lib Modified Files: imapoptions libconfig.c libconfig.h Log Message: Make MAXWORD and MAXQUOTED configurable >From Bron Gondwana : We've been patching our Cyrus at FastMail to make MAXWORD and MAXQUOTED much bigger, from 32k to 512k. This patch is a rework of our patch doing the following: 1) create two new config options "maxword" and "maxquoted" 2) use these options rather than hard coded limits 3) set the defaults to a nice halfway point: 128k. This avoids the "I use Cyrus on an embedded machine with 10Mb memory" vs "I have a shiny new machine with 32Gb of memory" (we have 2 of them now :)) argument. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/imapoptions.diff?r1=1.55&r2=1.56 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/libconfig.c.diff?r1=1.20&r2=1.21 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/libconfig.h.diff?r1=1.8&r2=1.9 From murch at andrew.cmu.edu Wed Sep 24 07:11:08 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Wed, 24 Sep 2008 07:11:08 EDT Subject: [Cyrus-CVS] src/cyrus/doc by murch Message-ID: <200809241111.m8OBB8HH003739@unix36.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/doc In directory unix36.andrew.cmu.edu:/var/tmp/cvs-serv3726/doc Modified Files: changes.html Log Message: getting ready for 2.3.13rc1 --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/doc/changes.html.diff?r1=1.158&r2=1.159 From murch at andrew.cmu.edu Wed Sep 24 07:11:08 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Wed, 24 Sep 2008 07:11:08 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809241111.m8OBB8SG003745@unix36.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix36.andrew.cmu.edu:/var/tmp/cvs-serv3726/imap Modified Files: version.h Log Message: getting ready for 2.3.13rc1 --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/version.h.diff?r1=1.154&r2=1.155 From murch at andrew.cmu.edu Wed Sep 24 07:11:08 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Wed, 24 Sep 2008 07:11:08 EDT Subject: [Cyrus-CVS] src/cyrus by murch Message-ID: <200809241111.m8OBB8WL003733@unix36.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus In directory unix36.andrew.cmu.edu:/var/tmp/cvs-serv3726 Modified Files: Makefile.in Log Message: getting ready for 2.3.13rc1 --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/Makefile.in.diff?r1=1.97&r2=1.98 From murch at andrew.cmu.edu Wed Sep 24 07:45:49 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Wed, 24 Sep 2008 07:45:49 EDT Subject: [Cyrus-CVS] src/cyrus/doc by murch Message-ID: <200809241145.m8OBjn83003779@unix24.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/doc In directory unix24.andrew.cmu.edu:/var/tmp/cvs-serv3774/doc Modified Files: changes.html Log Message: added support for fulldirhash to 'ctl_mboxlist -v' --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/doc/changes.html.diff?r1=1.159&r2=1.160 From murch at andrew.cmu.edu Wed Sep 24 07:45:50 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Wed, 24 Sep 2008 07:45:50 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809241145.m8OBjonn003785@unix24.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix24.andrew.cmu.edu:/var/tmp/cvs-serv3774/imap Modified Files: ctl_mboxlist.c Log Message: added support for fulldirhash to 'ctl_mboxlist -v' --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/ctl_mboxlist.c.diff?r1=1.62&r2=1.63 From murch at andrew.cmu.edu Wed Sep 24 07:56:41 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Wed, 24 Sep 2008 07:56:41 EDT Subject: [Cyrus-CVS] src/cyrus/lib by murch Message-ID: <200809241156.m8OBufp0004818@unix10.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/lib In directory unix10.andrew.cmu.edu:/var/tmp/cvs-serv4813 Modified Files: imapoptions Log Message: fixed gramatical nits --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/imapoptions.diff?r1=1.56&r2=1.57 From murch at andrew.cmu.edu Wed Sep 24 08:14:00 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Wed, 24 Sep 2008 08:14:00 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809241214.m8OCE0XG003774@unix32.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix32.andrew.cmu.edu:/var/tmp/cvs-serv3769 Modified Files: lmtpengine.c Log Message: control inclusion of Cyrus version in Received header with serverinfo imapd.conf option --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/lmtpengine.c.diff?r1=1.127&r2=1.128 From murch at andrew.cmu.edu Thu Sep 25 06:41:13 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Thu, 25 Sep 2008 06:41:13 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809251041.m8PAfDub005641@unix12.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix12.andrew.cmu.edu:/var/tmp/cvs-serv5636 Modified Files: imap_proxy.c Log Message: make sure that pipe_to_end_of_response() actually outputs the response --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/imap_proxy.c.diff?r1=1.9&r2=1.10 From murch at andrew.cmu.edu Thu Sep 25 07:24:48 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Thu, 25 Sep 2008 07:24:48 EDT Subject: [Cyrus-CVS] src/cyrus/contrib by murch Message-ID: <200809251124.m8PBOnOa004013@unix34.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/contrib In directory unix34.andrew.cmu.edu:/var/tmp/cvs-serv4008 Modified Files: drac_auth.patch Log Message: updated for 2.3.13 --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/contrib/drac_auth.patch.diff?r1=1.26&r2=1.27 From murch at andrew.cmu.edu Fri Sep 26 08:15:30 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Fri, 26 Sep 2008 08:15:30 EDT Subject: [Cyrus-CVS] src/cyrus/lib by murch Message-ID: <200809261215.m8QCFUS7007257@unix24.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/lib In directory unix24.andrew.cmu.edu:/var/tmp/cvs-serv7252 Modified Files: cyrusdb_skiplist.c Log Message: skiplist locking refactor >From Bron Gondwana : John Capo discovered a bug whereby foreach wasn't updating the transaction pointer before calling the handler function, so any updates during the foreach would fail if (and only if) it was the first database function to use that transaction. He posted a trivial patch to the mailing list which fixed the bug but left unreachable code. I decided that what was actually needed was a refactor of the 4 subtly different sets of locking on the access functions: fetch, foreach, store and delete into a single locking function. The attached match creates a new function lock_or_update(), and also always uses malloc and makes newtxn a "creation is initialisation" function for the transaction. It's a much neater way to handle transactions, and significantly clearer to read. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/cyrusdb_skiplist.c.diff?r1=1.62&r2=1.63 From murch at andrew.cmu.edu Fri Sep 26 09:30:00 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Fri, 26 Sep 2008 09:30:00 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809261330.m8QDU1GL008755@unix10.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix10.andrew.cmu.edu:/var/tmp/cvs-serv8750 Modified Files: proxy.c Log Message: prevent a hang in proxy_check_input() when prot_read() returns exactly 4096 bytes. also does not check for client input if there is server input (patch courtesy of Wes Craig ) --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/proxy.c.diff?r1=1.7&r2=1.8 From hdembkowski at alcatel-lucent.com Mon Sep 29 03:38:21 2008 From: hdembkowski at alcatel-lucent.com (DEMBKOWSKI, Henryk (Henryk)) Date: Mon, 29 Sep 2008 09:38:21 +0200 Subject: [Cyrus-CVS] src/cyrus/lib by murch In-Reply-To: <200809261215.m8QCFUS7007257@unix24.andrew.cmu.edu> References: <200809261215.m8QCFUS7007257@unix24.andrew.cmu.edu> Message-ID: Bron, Is it official patch for 2.3.12? Or maybe it is for 2.3.13. I thought that these changes will be included in "base" 2.3.13 But is seems that they are not. http://www.contrib.andrew.cmu.edu/~murch/cyrus-imapd-2.3.13rc1.tar.gz Kind Regards, Henryk -----Original Message----- From: cyrus-cvs-bounces at lists.andrew.cmu.edu [mailto:cyrus-cvs-bounces at lists.andrew.cmu.edu] On Behalf Of murch at andrew.cmu.edu Sent: Friday, September 26, 2008 2:16 PM To: cyrus-cvs at lists.andrew.cmu.edu Subject: [Cyrus-CVS] src/cyrus/lib by murch Update of /afs/andrew/system/cvs/src/cyrus/lib In directory unix24.andrew.cmu.edu:/var/tmp/cvs-serv7252 Modified Files: cyrusdb_skiplist.c Log Message: skiplist locking refactor >From Bron Gondwana : John Capo discovered a bug whereby foreach wasn't updating the transaction pointer before calling the handler function, so any updates during the foreach would fail if (and only if) it was the first database function to use that transaction. He posted a trivial patch to the mailing list which fixed the bug but left unreachable code. I decided that what was actually needed was a refactor of the 4 subtly different sets of locking on the access functions: fetch, foreach, store and delete into a single locking function. The attached match creates a new function lock_or_update(), and also always uses malloc and makes newtxn a "creation is initialisation" function for the transaction. It's a much neater way to handle transactions, and significantly clearer to read. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/cyrusdb_ skiplist.c.diff?r1=1.62&r2=1.63 From wes at umich.edu Mon Sep 29 10:26:40 2008 From: wes at umich.edu (Wesley Craig) Date: Mon, 29 Sep 2008 10:26:40 -0400 Subject: [Cyrus-CVS] src/cyrus/lib by murch In-Reply-To: References: <200809261215.m8QCFUS7007257@unix24.andrew.cmu.edu> Message-ID: <1E86EC88-17C3-4A95-8145-EBE097D0C986@umich.edu> On 29 Sep 2008, at 03:38, DEMBKOWSKI, Henryk ((Henryk)) wrote: > Is it official patch for 2.3.12? Or maybe it is for 2.3.13. 2.3.13 has not yet been released. The foreach-skiplist fix has been committed and will appear in the next release candidate (RC2). :wes From murch at andrew.cmu.edu Tue Sep 30 12:57:24 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 30 Sep 2008 12:57:24 EDT Subject: [Cyrus-CVS] src/cyrus/doc by murch Message-ID: <200809301657.m8UGvOO7009218@unix13.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/doc In directory unix13.andrew.cmu.edu:/var/tmp/cvs-serv9213/doc Modified Files: changes.html Log Message: updated --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/doc/changes.html.diff?r1=1.160&r2=1.161 From murch at andrew.cmu.edu Tue Sep 30 13:04:20 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 30 Sep 2008 13:04:20 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809301704.m8UH4KJQ018445@unix32.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix32.andrew.cmu.edu:/var/tmp/cvs-serv18418/imap Modified Files: mailbox.c Log Message: look for and fix 0 MODSEQ on upgrade (Wes Craig ) --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mailbox.c.diff?r1=1.180&r2=1.181 From murch at andrew.cmu.edu Tue Sep 30 13:06:06 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 30 Sep 2008 13:06:06 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809301706.m8UH66Yj012098@unix24.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix24.andrew.cmu.edu:/var/tmp/cvs-serv12065 Modified Files: index.c Log Message: Check for infinite loop on corrupted index files (Bron Gondwana ) --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/index.c.diff?r1=1.244&r2=1.245 From murch at andrew.cmu.edu Tue Sep 30 13:09:54 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 30 Sep 2008 13:09:54 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809301709.m8UH9sZS021438@unix36.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix36.andrew.cmu.edu:/var/tmp/cvs-serv21362 Modified Files: mupdate.c Log Message: preserve event order (Wes Craig ) The current event list is used first-in-last-out. This can result in events being delivered out of order. Multiple events on a single mailbox are especially problematic. This message: attempt to delete unknown mailbox %s on slaves is evidence of the order problem. --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mupdate.c.diff?r1=1.103&r2=1.104 From murch at andrew.cmu.edu Tue Sep 30 15:19:23 2008 From: murch at andrew.cmu.edu (murch at andrew.cmu.edu) Date: Tue, 30 Sep 2008 15:19:23 EDT Subject: [Cyrus-CVS] src/cyrus/imap by murch Message-ID: <200809301919.m8UJJNZ8013817@unix13.andrew.cmu.edu> Update of /afs/andrew/system/cvs/src/cyrus/imap In directory unix13.andrew.cmu.edu:/var/tmp/cvs-serv13812 Modified Files: imapd.c mboxlist.c Log Message: fix auto creation of INBOX (autocreatequota) --- links to diffs follow --- http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/imapd.c.diff?r1=1.551&r2=1.552 http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/imap/mboxlist.c.diff?r1=1.258&r2=1.259